ROX-28353: use NVD 2.0 JSON feeds #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTann
added
the
generate-dumps-on-pr
RTann
force-pushed
the
ROX-28353
branch
4 times, most recently
from
ae8b52c to
ee8b69f
Compare
RTann
commented
Aug 5, 2025
| @@ -31,6 +31,11 @@ func toJSON(vulns []*apischema.CVEAPIJSON20DefCVEItem) ([]*jsonschema.NVDCVEFeed | |||
| continue | |||
| } | |||
|
|
|||
| // Ignore rejected vulnerabilities. | |||
| if strings.EqualFold(vuln.CVE.VulnStatus, "Rejected") { | |||
There was a problem hiding this comment.
I vaguely recall there being some contention with us supporting rejected vulns in the past, and ignoring them as the solution, so your change tracks 👍
Is this covered by a test? If not, should it be?
There was a problem hiding this comment.
I didn't add any because they didn't exist before, but that's a bad reason to not add tests. Just added one which covers this rejected case and some basic stuff
4 tasks
BradLugo
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
Might be helpful to have a brief explanation of the difference between the feed and API, but I'm not sure where that should live. Maybe the feature flag comment? Either way, not gonna block on that. LGTM. Thanks for taking care of this, @RTann.
RTann
added a commit
that referenced
this pull request
Aug 7, 2025
RTann
added a commit
that referenced
this pull request
Aug 7, 2025
RTann
added a commit
that referenced
this pull request
Aug 7, 2025
RTann
added a commit
that referenced
this pull request
Aug 7, 2025
RTann
added a commit
that referenced
this pull request
Aug 7, 2025
RTann
added a commit
that referenced
this pull request
Aug 12, 2025
RTann
added a commit
that referenced
this pull request
Aug 14, 2025
RTann
added a commit
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVD will remove the 1.1 JSON feeds August 20, 2025, so this PR switches our feed loader to use the new 2.0 feeds. The schema is the same as the API, so this was pretty straightforward.
The NVD 2.0 API and feeds includes vulnerabilities with more NVD statuses than the 1.1 JSON feeds did (https://nvd.nist.gov/vuln/vulnerability-status). For example, "Deferred" vulnerabilities are included. As long as the vulnerability is not rejected and has all the fields we need, we do not care if NVD opted to change its status.
We should backport this to currently supported releases.